SS-1241 Include git-lfs in our standard jupyterlab image #75
Conversation
serve-jupyterlab/tests/test_api.py
Outdated
| assert lfs_init_val == "Git LFS initialized.", lfs_init_val | ||
| lfs_ver_val = cell_outputs[2] | ||
| assert type(lfs_ver_val) == str | ||
| assert lfs_ver_val == "git-lfs/3.0.2 (GitHub; linux amd64; go 1.18.1)", lfs_ver_val |
There was a problem hiding this comment.
Considering, that we are installing latest, it would be good to mention this for posterity, that it's okay that it fails and version here should be increased.
Or use fixed version in installation.
Or not check this so precise and just match, that there is git-lfs in the string.
Up to you:)
There was a problem hiding this comment.
Thank you. I initially actually thought to go for partial matching (your option number three), then I thought it's better to have a detailed error description for reference and clarity, incase there is a version related issue. I will add a comment here (your point number one), to make it clear.
There was a problem hiding this comment.
I think it should go at least into the error message, like "if the error is about different version, up the version". Otherwise it will be a process to figure it all out in the future.
Co-authored-by: Nikita Churikov <8545082+churnikov@users.noreply.github.com>
anondo1969
deleted the
SS-1241_Include_git-lfs_in_our_standard_jupyterlab_image
branch
Include git-lfs in our standard jupyterlab image
Source: SS-1241