Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pa11y_test.yaml #462

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

YvonneKallberg
Copy link
Collaborator

No description provided.

@YvonneKallberg YvonneKallberg linked an issue Jan 31, 2025 that may be closed by this pull request
@YvonneKallberg
Copy link
Collaborator Author

Is it as simple as replacing

  workflow_dispatch:
  schedule:
    - cron: '25 8,12 * * *'

with

  pull_request:
    push:
      branches:
        - main

If so, it's done, but how can one test?

@YvonneKallberg
Copy link
Collaborator Author

Hmm, check unsuccessful (plan page anchor wrong), due to the check being done on the site (which hasn't been redeployed after plan page was changed). Hence, what is the point of running pa11y at all, weekly or on PRs, if it only runs on deployed page?

@elinkronander elinkronander marked this pull request as ready for review February 5, 2025 14:08
@elinkronander elinkronander merged commit f0b796b into main Feb 5, 2025
2 of 3 checks passed
@elinkronander elinkronander deleted the 460-change-pa11y-to-run-on-pull-requests branch February 5, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change pa11y to run on pull requests
2 participants