Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pa11y to run on pull requests #460

Closed
YvonneKallberg opened this issue Jan 30, 2025 · 1 comment · Fixed by #462
Closed

Change pa11y to run on pull requests #460

YvonneKallberg opened this issue Jan 30, 2025 · 1 comment · Fixed by #462
Labels
help wanted Extra attention is needed

Comments

@YvonneKallberg
Copy link
Collaborator

Update accessibility testing (via pa11y_test.yaml) so that it runs automatically on pull requests instead of (?) running every Friday. '?' since I'm unsure but think that if we run on every pull request we don't have to run weekly. By running on PR:s we get notified immediately if we have introduced an accessibility 'error', which makes it easier to fix fast and not risking that the 'error' is deployed on website.

@YvonneKallberg
Copy link
Collaborator Author

Had a chat with Senthil regarding when running pa11y (for dsw appendix) and he said that one argument to run on weekly basis rather than on pull requests is if there is low frequencies on PRs (no development done) then the requirements on accessibility might change without one becoming aware until long time afterwards That is no risk for us, since the guidelines are actively developed, so I say we go ahead and change to run on PRs (only).

@YvonneKallberg YvonneKallberg linked a pull request Jan 31, 2025 that will close this issue
@YvonneKallberg YvonneKallberg added the help wanted Extra attention is needed label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant