ConstantInterpolation Extrapolation #387
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #378
I started working on this but then I found out this was already fxed by @DaniGlez in #379, but the issue wasn't closed. I did some nitpicking taking into account the
dir
of theConstantInterpolation
and the edgecase that there is only 1 datapoint.On a more general note, I see that we use
first
andlast
a lot (also in this PR) which only works properly ifu
is a vector (or at least indexed as such). We also have specialized methods for vector versus matrixu
. To ensure consistency and avoid code duplication, should we define custom indexing functions based on the type ofu
?