-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Base.length
methods for ViewAxis
and ComponentAxis
types
#294
base: main
Are you sure you want to change the base?
Conversation
This would be good to reduce the breakage from #249. I'm not sure how internal it was, but getting a ComponentIndex instead of an Int and a ViewAxis instead of a UnitRange seems pretty breaking. Perhaps it would make sense to add these as well:
|
@visr Sorry for the trouble. I've added a couple of methods that may fix your issue to this PR. Would you be able to try them out? |
@dingraha thanks a lot, that fixes all the issues we noticed with v0.15.23! |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This PR just adds
Base.length
methods for theViewAxis
andComponentIndex
types, which I find necessary in downstream packages.