Skip to content

Commit

Permalink
Issue #11 - Update Codebase to ABAP 7.40 SP 02
Browse files Browse the repository at this point in the history
Fixed some issues (Commit 2 / n)
  • Loading branch information
NeumannJoerg committed Jul 5, 2024
1 parent d59bf6f commit 565b446
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 49 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ CLASS /usi/cl_bal_ce_data_containers IMPLEMENTATION.
CONTINUE.
ENDTRY.

IF required_log_level->is_higher_than( i_log_level ) = abap_true
IF required_log_level->is_higher_than( i_log_level ) = abap_true

Check failure on line 69 in src/#usi#bal_cust_evaluation/#usi#cl_bal_ce_data_containers.clas.abap

View workflow job for this annotation

GitHub Actions / results

Remove double space

double_space
OR object_description->is_instantiatable( ) = abap_false

Check failure on line 70 in src/#usi#bal_cust_evaluation/#usi#cl_bal_ce_data_containers.clas.abap

View workflow job for this annotation

GitHub Actions / results

Fix in-statement indentation

in_statement_indentation
OR object_description->is_implementing( data_container_interface ) = abap_false.
CONTINUE.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,17 +86,15 @@ ENDCLASS.

CLASS lcl_unit_tests IMPLEMENTATION.
METHOD setup.
CREATE OBJECT test_double_cust_dao.
test_double_cust_dao = NEW #( ).
reset_cut( ).
ENDMETHOD.

METHOD reset_cut.
DATA exception TYPE REF TO /usi/cx_bal_root.

TRY.
CREATE OBJECT cut
EXPORTING
i_customizing_dao = test_double_cust_dao.
cut = NEW #( i_customizing_dao = test_double_cust_dao ).
CATCH /usi/cx_bal_root INTO exception.
/usi/cl_bal_aunit_exception=>abort_on_unexpected_exception( i_exception = exception
i_quit = if_aunit_constants=>method ).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,13 @@ CLASS /usi/cl_bal_cust_eval_factory DEFINITION PUBLIC FINAL CREATE PRIVATE.
"!
"! @parameter r_result | Instance
CLASS-METHODS get_instance
RETURNING
VALUE(r_result) TYPE REF TO /usi/if_bal_cust_eval_factory.
RETURNING VALUE(r_result) TYPE REF TO /usi/if_bal_cust_eval_factory.

"! Constructor
"!
"! @parameter i_dao_factory | DAO-Factory
METHODS constructor
IMPORTING
i_dao_factory TYPE REF TO /usi/if_bal_cust_dao_factory.

PROTECTED SECTION.
IMPORTING i_dao_factory TYPE REF TO /usi/if_bal_cust_dao_factory.

PRIVATE SECTION.
CLASS-DATA instance TYPE REF TO /usi/if_bal_cust_eval_factory.
Expand All @@ -27,85 +23,63 @@ CLASS /usi/cl_bal_cust_eval_factory DEFINITION PUBLIC FINAL CREATE PRIVATE.
ENDCLASS.



CLASS /usi/cl_bal_cust_eval_factory IMPLEMENTATION.
METHOD /usi/if_bal_cust_eval_factory~get_data_containers.
DATA dao TYPE REF TO /usi/if_bal_cd_data_containers.

dao = dao_factory->get_data_containers( ).
CREATE OBJECT r_result TYPE /usi/cl_bal_ce_data_containers
EXPORTING
i_customizing_dao = dao.
r_result = NEW /usi/cl_bal_ce_data_containers( i_customizing_dao = dao ).
ENDMETHOD.


METHOD /usi/if_bal_cust_eval_factory~get_exception_mapper.
DATA dao TYPE REF TO /usi/if_bal_cd_cx_mapper.

IF exception_mapper IS NOT BOUND.
dao = dao_factory->get_exception_mapper( ).
CREATE OBJECT exception_mapper TYPE /usi/cl_bal_ce_cx_mapper
EXPORTING
i_customizing_dao = dao.
exception_mapper = NEW /usi/cl_bal_ce_cx_mapper( i_customizing_dao = dao ).
ENDIF.

r_result = exception_mapper.
ENDMETHOD.


METHOD /usi/if_bal_cust_eval_factory~get_log_level_by_client.
DATA dao TYPE REF TO /usi/if_bal_cd_log_lv_by_clnt.

dao = dao_factory->get_log_level_by_client( ).
CREATE OBJECT r_result TYPE /usi/cl_bal_ce_log_lv_by_clnt
EXPORTING
i_customizing_dao = dao.
r_result = NEW /usi/cl_bal_ce_log_lv_by_clnt( i_customizing_dao = dao ).
ENDMETHOD.


METHOD /usi/if_bal_cust_eval_factory~get_log_level_by_log_object.
DATA dao TYPE REF TO /usi/if_bal_cd_log_lv_by_obj.

dao = dao_factory->get_log_level_by_log_object( ).
CREATE OBJECT r_result TYPE /usi/cl_bal_ce_log_lv_by_obj
EXPORTING
i_customizing_dao = dao.
r_result = NEW /usi/cl_bal_ce_log_lv_by_obj( i_customizing_dao = dao ).
ENDMETHOD.


METHOD /usi/if_bal_cust_eval_factory~get_log_level_by_user.
DATA dao TYPE REF TO /usi/if_bal_cd_log_lv_by_user.

dao = dao_factory->get_log_level_by_user( ).
CREATE OBJECT r_result TYPE /usi/cl_bal_ce_log_lv_by_user
EXPORTING
i_customizing_dao = dao.
r_result = NEW /usi/cl_bal_ce_log_lv_by_user( i_customizing_dao = dao ).
ENDMETHOD.


METHOD /usi/if_bal_cust_eval_factory~get_retention_parameters.
DATA dao TYPE REF TO /usi/if_bal_cd_retention.

dao = dao_factory->get_retention_parameters( ).
CREATE OBJECT r_result TYPE /usi/cl_bal_ce_retention
EXPORTING
i_customizing_dao = dao.
r_result = NEW /usi/cl_bal_ce_retention( i_customizing_dao = dao ).
ENDMETHOD.


METHOD constructor.
dao_factory = i_dao_factory.
ENDMETHOD.


METHOD get_instance.
DATA dao_factory TYPE REF TO /usi/if_bal_cust_dao_factory.

IF instance IS NOT BOUND.
CREATE OBJECT dao_factory TYPE /usi/cl_bal_cust_dao_factory.
CREATE OBJECT instance TYPE /usi/cl_bal_cust_eval_factory
EXPORTING
i_dao_factory = dao_factory.
dao_factory = NEW /usi/cl_bal_cust_dao_factory( ).
instance = NEW /usi/cl_bal_cust_eval_factory( i_dao_factory = dao_factory ).
ENDIF.

r_result = instance.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,9 @@ ENDCLASS.

CLASS /usi/cl_bal_log_object_range IMPLEMENTATION.
METHOD insert_line.
DATA range_line TYPE /usi/bal_log_object_range_line.

range_line-sign = i_sign.
range_line-option = i_option.
range_line-low = i_low.
range_line-high = i_high.

INSERT range_line INTO TABLE range.
INSERT VALUE #( sign = i_sign
option = i_option
low = i_low
high = i_high ) INTO TABLE range.
ENDMETHOD.
ENDCLASS.

0 comments on commit 565b446

Please sign in to comment.