Add package 'concurrency' with struct ParallelWorker, include doc and example as test #133
Conversation
… example as test FYI 'go test' execute the Example and compare the output as the comment // Output: [...]
concurrency/parallel_worker.go
Outdated
|
|
||
| // Stop should be called to release all resources. It waits for all the runnings | ||
| // tasks to be over Calling Perform after this would result in a panic | ||
| func (w ParallelWorker) Stop() { |
There was a problem hiding this comment.
I don't find the function name good. I think it does not reflect the fact that it's actually a wait. Maybe WaitAndDone or WaitAndFinish?
There was a problem hiding this comment.
@EtienneM would Complete() would be better? =p
There was a problem hiding this comment.
I'm not sure. The Stop method is really just a wait operation. And from my perspective, Complete is not clear about the face that the method will block until the computation is over.
There was a problem hiding this comment.
I've used CompleteProcessing
In English it sounds semantically quite good to me, what do you think?
It's about the |
Co-authored-by: Étienne M. <EtienneM@users.noreply.github.com>
Soulou
force-pushed
the
package/concurrency/parallel_worker
branch
from
9608b93 to
3ffa47b
Compare
Co-authored-by: Étienne M. <EtienneM@users.noreply.github.com>
|
@EtienneM specs are failing because of another package I would be really grateful if it would be merged =P |
|
(one build succeeds though!) |
|
OK, I opened an issue about these random specs (#134). |
FYI 'go test' execute the Example and compare the output as the comment // Output: [...]