feat(otel): add module for our OpenTelemetry SDK wrapper #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SCKevinO
force-pushed
the
feat/1044/otel-sdk
branch
from
c567042 to
9682ccc
Compare
brandon-welsch
requested changes
Feb 5, 2025
otel/README.md
Outdated
Comment on lines
17
to
22
| // Get Otel configuration from environment | ||
| var otelConfig otel.Config | ||
| err := envconfig.Process("OTEL", &otelConfig) | ||
| if err != nil { | ||
| return | ||
| } |
There was a problem hiding this comment.
I think we can handle this directly in our package, in order to not repeat the same thing between services and keep a consistent code
brandon-welsch
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1044
CHANGELOG.md