[NUI] Public APIs Copy, Cut, Paste and SelectText #1736

shrouqsabah · 2022-11-27T21:37:05Z

Change Description

Public APIs Copy, Cut, Paste and SelectedText in TextField or TextEditor

According to ACR request.
We need to explain how to use public APIs Copy, Cut, Paste and SelectedText in TextField or TextEditor.

Added at the end of docs in "docs/application/dotnet/guides/user-interface/nui/text.md" a header.
The header is "Use public APIs Copy, Cut, Paste and SelectedText in TextField or TextEditor"
Explained APIs and added sequence of steps how to use them together.

For instance,

Issue Public APIs Copy, Cut, Paste and SelectedText in TextField or TextEditor #1735

API Changes

For instance,

ACR: ACR-455

TizenDocsBot · 2022-11-27T21:45:49Z

checkout the webpage https://docs1.stg.tizen.org/staging/1736/

TizenDocsBot · 2022-11-27T21:45:57Z

Check Broken Link: Not found any broken link

TizenDocsBot · 2022-11-27T21:46:01Z

omar-srbd

Hello @shrouqsabah, I hope you are doing well.
I have checked the parts from your commit and left some correction suggestions.
Please incorporate them at your earliest convenience.
Thank you.

docs/application/dotnet/guides/user-interface/nui/text.md

TizenDocsBot · 2022-12-04T22:03:51Z

checkout the webpage https://docs1.stg.tizen.org/staging/1736/

TizenDocsBot · 2022-12-04T22:04:04Z

Check Broken Link: Not found any broken link

TizenDocsBot · 2022-12-04T22:04:07Z

omar-srbd

Hello @shrouqsabah, thanks for your most recent commit implementing the changes.
After another check of the file I have found a few more issues that need to be addressed, please incorporate the changes at your earliest convenience.
Thanks.

docs/application/dotnet/guides/user-interface/nui/text.md

TizenDocsBot · 2022-12-05T08:35:56Z

checkout the webpage https://docs1.stg.tizen.org/staging/1736/

TizenDocsBot · 2022-12-05T08:36:04Z

Check Broken Link: Not found any broken link

TizenDocsBot · 2022-12-05T08:36:09Z

omar-srbd

@shrouqsabah, thanks for incorporating all the changes as per the suggestion.

@asm-foysal @mijin85cho, I am approving this PR for merging.

asm-foysal · 2022-12-09T06:10:54Z

@omar-srbd is the heading count right? This file looks like it should be a second heading (at the same level as TextField and TextEditor) since it's reflecting data for both those sections... Also, the heading name seems too big, could we shorten it somehow?
@mijin85cho what do you think?

mijin85cho · 2022-12-09T07:10:05Z

@omar-srbd is the heading count right? This file looks like it should be a second heading (at the same level as TextField and TextEditor) since it's reflecting data for both those sections... Also, the heading name seems too big, could we shorten it somehow? @mijin85cho what do you think?

I agree to your comments.

According to the context, this new paragraph would be much better to use 2nd heading.
The title would be better to shorten if possible. Concise title is recommended.

omar-srbd · 2022-12-09T09:20:11Z

docs/application/dotnet/guides/user-interface/nui/text.md

@@ -756,6 +756,105 @@ The following table lists the available `TextEditor` properties:
 | `TranslatableText`                 | String      | Specifies the `TranslatableText` property that sets the SID value. |


+### Use public APIs to copy, cut, paste, and select text in TextField or TextEditor


Hello @shrouqsabah, I had a query regarding the heading.
The heading here seems to be a bit too long, we recommend using something concise for headings.

In this case, could you please clarify if the heading should emphasize the functionality of Copy, cut, paste, and select text or the usage of public APIs? Depending on your clarification I can provide an alternate for the heading or it would be better if you could change the heading to something concise.

Thank you.

Hello @omar-srbd ,
We need to explain how to use APIs.
Here's the original request from ACR.
TCSACR-455 : Please add how to use new APIs. When you update the API guides, it will be good if you add how to use SelectedText API.

Let's me know what you suggest :)
Thanks

@omar-srbd What do you think about this ( How to use Clipboard APIs with Select Text )?

@shrouqsabah,

I have left another review incorporating your suggestion for the heading.
Please look into it and update accordingly.

Thanks.

omar-srbd

Hello @shrouqsabah,

Please update the heading accordingly.

Thanks you.

omar-srbd · 2022-12-13T05:37:30Z

docs/application/dotnet/guides/user-interface/nui/text.md

@@ -756,6 +756,105 @@ The following table lists the available `TextEditor` properties:
 | `TranslatableText`                 | String      | Specifies the `TranslatableText` property that sets the SID value. |


+### Use public APIs to copy, cut, paste, and select text in TextField or TextEditor


Suggested change

### Use public APIs to copy, cut, paste, and select text in TextField or TextEditor

## How to use clipboard APIs with select text

TizenDocsBot · 2022-12-13T06:54:17Z

checkout the webpage https://docs1.stg.tizen.org/staging/1736/

TizenDocsBot · 2022-12-13T06:54:27Z

Check Broken Link: Not found any broken link

omar-srbd

@shrouqsabah, after another review I found a few more issues that need to be addressed and left correction suggestions for them.
Please incorporate them at your convenience.

docs/application/dotnet/guides/user-interface/nui/text.md

omar-srbd · 2022-12-14T09:18:43Z

docs/application/dotnet/guides/user-interface/nui/text.md

+
+```csharp
+// Step 04: Select text from source text filed
+textFieldSrc.SelectText (0,8); // "Welcome!" is the selected text


I have a doubt regarding the selected text based on the declared indexes (0,8).
According to your declared indexes, the selected text should not include a space after the exclamation mark (!).
Can you please check this?

Suggested change

textFieldSrc.SelectText (0,8); // "Welcome!" is the selected text

textFieldSrc.SelectText (0,7); // "Welcome!" is the selected text

Checked.
I added the below note for description of SelectText. And fixed the first example:
`

Note
The selected text includes the start index.
But, the selected text does not include the end index.

textFieldSrc.SelectText (9,16); //"This is" is the selected text
`

docs/application/dotnet/guides/user-interface/nui/text.md

TizenDocsBot · 2022-12-14T22:13:57Z

checkout the webpage https://docs1.stg.tizen.org/staging/1736/

TizenDocsBot · 2022-12-14T22:14:05Z

Check Broken Link: Not found any broken link

omar-srbd

@shrouqsabah, after a review of your last commit, I found one issue that needs to be addressed.
Please check the suggestion and incorporate the change accordingly.
Thanks.

omar-srbd · 2022-12-15T06:17:36Z

docs/application/dotnet/guides/user-interface/nui/text.md

+   > The selected text includes the start index.
+   > But, the selected text does not include the end index.


Suggested change

> The selected text includes the start index.

> But, the selected text does not include the end index.

> The selected text includes the start index, but it does not include the end index.

@omar-srbd ,
Done. Thank you,

TizenDocsBot · 2022-12-15T06:39:13Z

checkout the webpage https://docs1.stg.tizen.org/staging/1736/

TizenDocsBot · 2022-12-15T06:39:26Z

Check Broken Link: Not found any broken link

omar-srbd

@shrouqsabah, thanks for incorporating all the suggested changes.

@mijin85cho @asm-foysal I am approving this PR for merging.

safir-srbd · 2022-12-20T11:20:52Z

docs/application/dotnet/guides/user-interface/nui/text.md

@@ -756,6 +756,108 @@ The following table lists the available `TextEditor` properties:
 | `TranslatableText`                 | String      | Specifies the `TranslatableText` property that sets the SID value. |


+## How to use clipboard APIs with select text


@shrouqsabah Hello. Hope you are well!

After checking before merging, I have a query regarding this PR.

In the heading, you have mentioned SelectedText, but in your changes here, you have written SelectText API. From what I have observed, SelectText is the appropriate name, as mentioned here. Can you please confirm if it should be SelectedText API or SelectText API?

@safir-srbd , Hello, I hope you well too.
Yes, you are right. It should be SelectText.
I will update title.

@shrouqsabah Thank you for your response!

In that case, I have a heading suggestion for this section which would be more aligned with the rest of the titles in this document.
What do you think of "Use clipboard and SelectText APIs" as the heading?
If it seems ok, please update it and we can merge this PR.

…extEditor

TizenDocsBot · 2022-12-21T12:39:04Z

checkout the webpage https://docs1.stg.tizen.org/staging/1736/

TizenDocsBot · 2022-12-21T12:39:16Z

Check Broken Link: Not found any broken link

TizenDocsBot · 2022-12-21T12:46:33Z

checkout the webpage https://docs1.stg.tizen.org/staging/1736/

TizenDocsBot · 2022-12-21T12:46:41Z

Check Broken Link: Not found any broken link

safir-srbd

@shrouqsabah Thank you for making the suggested change. All my comments have been addressed.

I am approving this PR for merging.

shrouqsabah requested review from journey2w, mijin85cho and asm-foysal as code owners November 27, 2022 21:37

omar-srbd reviewed Nov 29, 2022

View reviewed changes

shrouqsabah force-pushed the nui_acr_455 branch from 3f2c81b to 5114472 Compare December 4, 2022 21:56

omar-srbd reviewed Dec 5, 2022

View reviewed changes

shrouqsabah force-pushed the nui_acr_455 branch from 5114472 to d107e32 Compare December 5, 2022 08:28

omar-srbd approved these changes Dec 6, 2022

View reviewed changes

omar-srbd reviewed Dec 9, 2022

View reviewed changes

omar-srbd reviewed Dec 13, 2022

View reviewed changes

shrouqsabah force-pushed the nui_acr_455 branch from d107e32 to 2ddce5b Compare December 13, 2022 06:46

omar-srbd reviewed Dec 14, 2022

View reviewed changes

shrouqsabah force-pushed the nui_acr_455 branch from 2ddce5b to f1bd643 Compare December 14, 2022 22:06

omar-srbd reviewed Dec 15, 2022

View reviewed changes

shrouqsabah force-pushed the nui_acr_455 branch from f1bd643 to 2cff543 Compare December 15, 2022 06:31

omar-srbd approved these changes Dec 20, 2022

View reviewed changes

safir-srbd reviewed Dec 20, 2022

View reviewed changes

shrouqsabah changed the title ~~[NUI] Public APIs Copy, Cut, Paste and SelectedText~~ [NUI] Public APIs Copy, Cut, Paste and SelectText Dec 20, 2022

shrouqsabah force-pushed the nui_acr_455 branch from 2cff543 to a1d4071 Compare December 21, 2022 12:31

[NUI] Public APIs Copy, Cut, Paste and SelectedText in TextField or T…

f287db7

…extEditor

shrouqsabah force-pushed the nui_acr_455 branch from a1d4071 to f287db7 Compare December 21, 2022 12:35

safir-srbd approved these changes Dec 22, 2022

View reviewed changes

asm-foysal merged commit 95b54d0 into Samsung:master Dec 26, 2022

omar-srbd mentioned this pull request Jan 31, 2023

Update text.md under dotnet #1767

Merged

		@@ -756,6 +756,105 @@ The following table lists the available `TextEditor` properties:
		\| `TranslatableText` \| String \| Specifies the `TranslatableText` property that sets the SID value. \|


		### Use public APIs to copy, cut, paste, and select text in TextField or TextEditor

	### Use public APIs to copy, cut, paste, and select text in TextField or TextEditor
	## How to use clipboard APIs with select text

	textFieldSrc.SelectText (0,8); // "Welcome!" is the selected text
	textFieldSrc.SelectText (0,7); // "Welcome!" is the selected text

		> The selected text includes the start index.
		> But, the selected text does not include the end index.

		@@ -756,6 +756,108 @@ The following table lists the available `TextEditor` properties:
		\| `TranslatableText` \| String \| Specifies the `TranslatableText` property that sets the SID value. \|


		## How to use clipboard APIs with select text

[NUI] Public APIs Copy, Cut, Paste and SelectText #1736

[NUI] Public APIs Copy, Cut, Paste and SelectText #1736

Conversation

shrouqsabah commented Nov 27, 2022

Change Description

API Changes

TizenDocsBot commented Nov 27, 2022

TizenDocsBot commented Nov 27, 2022

TizenDocsBot commented Nov 27, 2022

omar-srbd left a comment

Choose a reason for hiding this comment

TizenDocsBot commented Dec 4, 2022

TizenDocsBot commented Dec 4, 2022

TizenDocsBot commented Dec 4, 2022

omar-srbd left a comment

Choose a reason for hiding this comment

TizenDocsBot commented Dec 5, 2022

TizenDocsBot commented Dec 5, 2022

TizenDocsBot commented Dec 5, 2022

omar-srbd left a comment

Choose a reason for hiding this comment

asm-foysal commented Dec 9, 2022

mijin85cho commented Dec 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

omar-srbd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TizenDocsBot commented Dec 13, 2022

TizenDocsBot commented Dec 13, 2022

omar-srbd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TizenDocsBot commented Dec 14, 2022

TizenDocsBot commented Dec 14, 2022

omar-srbd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TizenDocsBot commented Dec 15, 2022

TizenDocsBot commented Dec 15, 2022

omar-srbd left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TizenDocsBot commented Dec 21, 2022

TizenDocsBot commented Dec 21, 2022

TizenDocsBot commented Dec 21, 2022

TizenDocsBot commented Dec 21, 2022

safir-srbd left a comment

Choose a reason for hiding this comment

mijin85cho commented Dec 9, 2022 •

edited

Loading