Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[circle-mlir] Initial U2204 Dockerfile for CI #14616

Merged
merged 2 commits into from
Feb 10, 2025
Merged

[circle-mlir] Initial U2204 Dockerfile for CI #14616

merged 2 commits into from
Feb 10, 2025

Conversation

seanshpark
Copy link
Contributor

This will introduce initial U2204 Dockerfile for CI build check.

@seanshpark
[circle-mlir] Initial U2204 Dockerfile for CI
a63097f 
This will introduce initial U2204 Dockerfile for CI build check.

ONE-DCO-1.0-Signed-off-by: SaeHie Park <saehie.park@gmail.com>
@seanshpark
Copy link
Contributor Author

@seanshpark seanshpark added the DRAFT A draft issue or PR for sharing one's current working status and discussion. label Feb 6, 2025
@seanshpark
Copy link
Contributor Author

seanshpark commented Feb 7, 2025 •
edited
Loading

local image build

docker build -t circle-mlir-build .

@seanshpark
Copy link
Contributor Author

my initial local build: https://hub.docker.com/r/seanshpark/circle-mlir-build-2204

@seanshpark seanshpark removed the DRAFT A draft issue or PR for sharing one's current working status and discussion. label Feb 10, 2025
@seanshpark seanshpark requested a review from a team February 10, 2025 00:09
shs-park
shs-park approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@shs-park shs-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Would it be okay if I use this PR to start applying it to other Ubuntu distributions(20.04) as well?

@seanshpark
Copy link
Contributor Author

Would it be okay if I use this PR to start applying it to other Ubuntu distributions(20.04) as well?

My following plan is to
(1) build and upload to Docker hub with nnfw account in Workflow
(2) prepare a build check Workflow and land
(3) prepare a draft with minumum circle-mlir codes with simple Op(like Add or Sin)
(4) fix any problems
(5) split (3) to small PRs

IMHO, it is OK to land for 20.04 but that may require additional changes if encounter any problems.

@seanshpark seanshpark merged commit 8c9f6b2 into Samsung:master Feb 10, 2025
3 checks passed
@seanshpark seanshpark deleted the circlemlir_docker_u2204 branch February 10, 2025 01:18
@seanshpark seanshpark mentioned this pull request Feb 10, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs-park shs-park shs-park approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanshpark @shs-park