Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert/python] Introduce metric API #14544

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

ragmani
Copy link
Contributor

@ragmani ragmani commented Jan 13, 2025

This commit introduces metric APIs.

  • categorical_accuracy.py : CategoricalAccuracy class
  • metric : Metric class to be provided custom metric

ONE-DCO-1.0-Signed-off-by: ragmani ragmani0216@gmail.com

This commit introduces metric APIs.
  - categorical_accuracy.py : CategoricalAccuracy class
  - metric : Metric class to be provided custom metric

ONE-DCO-1.0-Signed-off-by: ragmani <ragmani0216@gmail.com>
@ragmani ragmani requested a review from a team January 13, 2025 07:21
@ragmani
Copy link
Contributor Author

ragmani commented Jan 13, 2025

For #14505
Draft : #14492

@ragmani ragmani added the PR/ready for review It is ready to review. Please review it. label Jan 13, 2025
Copy link
Contributor

@zetwhite zetwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hseok-oh
Copy link
Contributor

BTW, doesn't we need validation check test for python API?

@hseok-oh hseok-oh merged commit a2c1f28 into Samsung:master Jan 15, 2025
12 checks passed
@ragmani
Copy link
Contributor Author

ragmani commented Jan 15, 2025

BTW, doesn't we need validation check test for python API?

What validation do we need? Test code using python API?

@ragmani ragmani deleted the onert/python/add_metrics branch January 15, 2025 10:22
@hseok-oh
Copy link
Contributor

What validation do we need? Test code using python API?

Right. And we should not forget that python also have same release criteria with C/C++ code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants