Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onert-micro] Enable ReducedProd op #14510

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chunseoklee
Copy link
Contributor

  • enable reduced product operation in onert-micro
  • Note that prevoious name for ReducedProd is ReducedCommon(?)

ONE-DCO-1.0-Signed-off-by: Chunseok Lee chunseok.lee@samsung.com

- enable reduced product operation in onert-micro
- Note that prevoious name for ReducedProd is ReducedCommon(?)

ONE-DCO-1.0-Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
@chunseoklee chunseoklee requested a review from SlavikMIPT January 3, 2025 06:27
@chunseoklee chunseoklee marked this pull request as ready for review January 3, 2025 06:27
@chunseoklee chunseoklee requested a review from Torrero January 16, 2025 04:39
Torrero
Torrero previously approved these changes Jan 22, 2025
Copy link
Contributor

@Torrero Torrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SlavikMIPT SlavikMIPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, please fix include guard

onert-micro/onert-micro/include/pal/mcu/PALReduceCommon.h Outdated Show resolved Hide resolved
Co-authored-by: SlavikMIPT <slavikmipt@gmail.com>
Copy link
Contributor

@Torrero Torrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants