Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cast product id to number #530

Closed
wants to merge 1 commit into from
Closed

Conversation

musta20
Copy link

@musta20 musta20 commented Jan 23, 2025

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bug fix

What is the current behaviour? (You can also link to an open issue here)

  • the product-card.js is not showing red heart when the product is in wishlist
  • because the salla.storage.get('salla::wishlist', []) return array of integer number and the includes(this.product.id) is returning a string causing a mismatch bug the component fail to recognize the id in the array not sure if the error just in my themes .

What is the new behaviour? (You can also link to the ticket here)

  • when the product is in wishlist the heart icon will be red

Does this PR introduce a breaking change?

Screenshots (If appropriate)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@SallaDev SallaDev marked this pull request as draft January 23, 2025 12:41
@musta20
Copy link
Author

musta20 commented Feb 10, 2025

issue got fixed wish-list now is numbers

@musta20 musta20 closed this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant