From 613449888b9769dd9a83f1e9c5593eaae6531826 Mon Sep 17 00:00:00 2001 From: Salad Dais Date: Tue, 26 Mar 2024 14:33:20 -0700 Subject: [PATCH] Be more polite about overriding virtual functions --- CMakeLists.txt | 2 +- libtailslide/passes/desugaring.hh | 2 ++ libtailslide/passes/globalexpr_validator.hh | 3 +++ 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ed31173..b4baf35 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -28,7 +28,7 @@ if (MSVC) add_definitions("-D_CRT_SECURE_NO_WARNINGS=1") else() # Don't whine about using sprintf() in doctest - add_definitions("-Wall -Wno-overloaded-virtual -Wno-deprecated-declarations") + add_definitions("-Wall -Wno-deprecated-declarations") if (NOT CMAKE_CXX_COMPILER_ID STREQUAL "GNU") add_definitions("-Wno-unneeded-internal-declaration") endif() diff --git a/libtailslide/passes/desugaring.hh b/libtailslide/passes/desugaring.hh index 4b1f93e..c7d138d 100644 --- a/libtailslide/passes/desugaring.hh +++ b/libtailslide/passes/desugaring.hh @@ -45,6 +45,8 @@ class LLConformantDeSugaringVisitor : public DeSugaringVisitor { : DeSugaringVisitor(allocator, mono_semantics) {}; protected: bool visit(LSLConstantExpression *constant_expr) override; + // Make things stop complaining about hidden virtual functions + using DeSugaringVisitor::visit; LSLASTNode *rewriteBuiltinLValue(LSLLValueExpression *lvalue) override; }; diff --git a/libtailslide/passes/globalexpr_validator.hh b/libtailslide/passes/globalexpr_validator.hh index 7b0e02b..fefd9d2 100644 --- a/libtailslide/passes/globalexpr_validator.hh +++ b/libtailslide/passes/globalexpr_validator.hh @@ -31,6 +31,9 @@ class SimpleAssignableValidatingVisitor: public GlobalExprValidatingVisitor { bool visit(LSLExpression *expr) override; bool visit(LSLUnaryExpression *unary_expr) override; bool visit(LSLLValueExpression *lvalue) override; + // Make things stop complaining about hidden virtual functions + using GlobalExprValidatingVisitor::visit; + bool _mMonoSemantics; };