Be more polite about overriding virtual functions

SaladDais · Mar 26, 2024 · 6134498 · 6134498
1 parent ad1021c
commit 6134498
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 1 deletion.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -28,7 +28,7 @@ if (MSVC)
   add_definitions("-D_CRT_SECURE_NO_WARNINGS=1")
 else()
   # Don't whine about using sprintf() in doctest
-  add_definitions("-Wall -Wno-overloaded-virtual -Wno-deprecated-declarations")
+  add_definitions("-Wall -Wno-deprecated-declarations")
   if (NOT CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
     add_definitions("-Wno-unneeded-internal-declaration")
   endif()

diff --git a/libtailslide/passes/desugaring.hh b/libtailslide/passes/desugaring.hh
@@ -45,6 +45,8 @@ class LLConformantDeSugaringVisitor : public DeSugaringVisitor {
         : DeSugaringVisitor(allocator, mono_semantics) {};
   protected:
     bool visit(LSLConstantExpression *constant_expr) override;
+    // Make things stop complaining about hidden virtual functions
+    using DeSugaringVisitor::visit;
 
     LSLASTNode *rewriteBuiltinLValue(LSLLValueExpression *lvalue) override;
 };

diff --git a/libtailslide/passes/globalexpr_validator.hh b/libtailslide/passes/globalexpr_validator.hh
@@ -31,6 +31,9 @@ class SimpleAssignableValidatingVisitor: public GlobalExprValidatingVisitor {
     bool visit(LSLExpression *expr) override;
     bool visit(LSLUnaryExpression *unary_expr) override;
     bool visit(LSLLValueExpression *lvalue) override;
+    // Make things stop complaining about hidden virtual functions
+    using GlobalExprValidatingVisitor::visit;
+
     bool _mMonoSemantics;
 };