Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is not clear that INEQR takes a multi-dimensional pixel_vals list as input #74

Open
SaashaJoshi opened this issue Mar 23, 2024 · 2 comments
Labels
design-issue This is a design issue and requires major change documentation Improvements or additions to documentation

Comments

@SaashaJoshi
Copy link
Owner

In INEQR, the pixel_pos_binary needs to be a binary string y_coord+x_coord long. However, currently, the code misrepresents the binary with extra 0 padding.

for y_index, y_val in enumerate(self.pixel_vals):
for x_index, x_val in enumerate(y_val):
pixel_pos_binary = (
f"{y_index:0>{self.y_coord}b}{x_index:0>{self.x_coord}b}"
)

@SaashaJoshi SaashaJoshi added bug Something isn't working documentation Improvements or additions to documentation labels Mar 23, 2024
@SaashaJoshi
Copy link
Owner Author

INEQR takes a multi-dimensional pixel_val input to support unequal horizontal and vertical image dimensions. The code works perfectly.
However, this requirement needs to be made clear to the user.

@SaashaJoshi SaashaJoshi changed the title INEQR has inconsistent pixel_pos_binary values It is not clear that INEQR takes a multi-dimensional pixel_vals list as input Mar 23, 2024
@SaashaJoshi SaashaJoshi added design-issue This is a design issue and requires major change and removed bug Something isn't working labels Mar 23, 2024
@SaashaJoshi
Copy link
Owner Author

SaashaJoshi commented Mar 27, 2024

One of the INEQR tests currently fails and is temporarily ignored. #80 #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-issue This is a design issue and requires major change documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant