-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for circuit cutting in TNs #51
Comments
Hi @SaashaJoshi I would like to work on this task for Hacktoberfest. |
Hi @tinaoberoi, that's great. |
Hi @tinaoberoi, let me know if you need help at any moment or wish to discuss things going forward. |
Hi @SaashaJoshi
And for the next steps we can add module to modify the circuit_knitting source code to overcome blockers like "allowing only single cuts" |
This is great. I am thinking along similar lines. I believe classes like SamplerQNN and EstimatorQNN from the Qiskit Machine Learning library need to be modified to make them compatible with circuit cutting structures. This is because tensor networks need to be trained iteratively after a cut has been made on them and these classes do not readily accept multiple circuits that can be executed simultaneously. However, modifying these classes or adding a module from scratch might be too much work for Hacktoberfest. If you are focused on Hacktoberfest, then quite honestly, I do not think this issue will be a good fit. Also, you will have to show some merged pull requests to complete the Hacktoberfest requirements, which may not happen immediately with this issue. But if you wish to discuss things irrespective of the event I am all ears. |
I would like to work on this irrespective of Hacktoberfest. What do you think will be better approach, I was thinking of adding a wrapper module so that we can add additional functionalities going forward. |
Perfect! A wrapper can be a good alternative to explore. Although I was thinking more along the lines of making the entire training module from scratch, however, starting with a wrapper class/function is good. Do you have some specifics on what the wrapper must do? |
Why is that the case? (Is it the limitatiion of the machine learning library in general or because of the subcircuits being depenedent). I found this as a way to parallelise QNN training
I agree writing a training module should be the final step, but a wrapper will help me familiarize with the modules. |
HI @tinaoberoi,
It is mainly because of how the functions are structured in Qiskit Machine Learning library. I'll be honest, I haven't had the latest look after Feb 2024. A wrapper function sounds good. Let me know if you'd need any help in making a PR etc. We should think more about its structure etc. |
Refer:
The text was updated successfully, but these errors were encountered: