Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added rule on colons #309

Merged
merged 4 commits into from
Jan 16, 2025
Merged

Added rule on colons #309

merged 4 commits into from
Jan 16, 2025

Conversation

dariavladykina
Copy link
Contributor

Added one style rule about colons according to this.

tbazant
tbazant reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@tbazant tbazant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the 2 examples capitalizes the 1st word after a colon. I assume the But should announce a contrast?!?

janajaeger
janajaeger reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@janajaeger janajaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to agree with Tomas. This is very hard to parse. You would need about 3 litres of coffee. Rephrase maybe?

@dariavladykina
Copy link
Contributor Author

Oops, sorry! I got a wrong example in there. Fixed now with correct examples.

tbazant
tbazant approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@tbazant tbazant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now, thanks

jfaltenbacher
jfaltenbacher approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@jfaltenbacher jfaltenbacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

janajaeger
janajaeger reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@janajaeger janajaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. This is sooooo much better!

@dariavladykina dariavladykina merged commit 4a6684c into main Jan 16, 2025
4 checks passed
@dariavladykina dariavladykina deleted the vlada/add_style_rules branch January 16, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbazant tbazant tbazant approved these changes

@jfaltenbacher jfaltenbacher jfaltenbacher approved these changes

@janajaeger janajaeger janajaeger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dariavladykina @tbazant @jfaltenbacher @janajaeger