-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
21 changed files
with
672 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
src/Surfnet/ServiceProviderDashboard/Domain/Service/OidcCreateEntityEnabledMarshaller.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * Copyright 2019 SURFnet B.V. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| namespace Surfnet\ServiceProviderDashboard\Domain\Service; | ||
|
|
||
| /** | ||
| * Is the application configured to allow creation of OIDC entities | ||
| */ | ||
| class OidcCreateEntityEnabledMarshaller | ||
| { | ||
| private $isAllowed = false; | ||
|
|
||
| public function __construct($isAllowed) | ||
| { | ||
| $this->isAllowed = $isAllowed; | ||
| } | ||
|
|
||
| /** | ||
| * @return bool | ||
| */ | ||
| public function allowed() | ||
| { | ||
| return $this->isAllowed; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
172 changes: 172 additions & 0 deletions
172
tests/unit/Infrastructure/DashboardBundle/Form/Entity/ProtocolChoiceFactoryTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,172 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * Copyright 2019 SURFnet B.V. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| namespace Surfnet\ServiceProviderDashboard\Tests\Unit\Infrastructure\DashboardBundle\Form\Entity; | ||
|
|
||
| use Mockery as m; | ||
| use Mockery\Adapter\Phpunit\MockeryTestCase; | ||
| use Surfnet\ServiceProviderDashboard\Application\ViewObject\Manage\Config; | ||
| use Surfnet\ServiceProviderDashboard\Domain\Entity\Entity; | ||
| use Surfnet\ServiceProviderDashboard\Domain\Entity\Service; | ||
| use Surfnet\ServiceProviderDashboard\Domain\Service\OidcCreateEntityEnabledMarshaller; | ||
| use Surfnet\ServiceProviderDashboard\Infrastructure\DashboardBundle\Form\Entity\ProtocolChoiceFactory; | ||
|
|
||
| class ProtocolChoiceFactoryTest extends MockeryTestCase | ||
| { | ||
| /** @var ProtocolChoiceFactory */ | ||
| private $protocolChoiceFactory; | ||
| /** @var m\MockInterface&OidcCreateEntityEnabledMarshaller */ | ||
| private $oidcCreateEnabledMarshaller; | ||
| /** @var m\MockInterface&Config */ | ||
| private $manageTestConfig; | ||
| /** @var m\MockInterface&Config */ | ||
| private $manageProdConfig; | ||
| /** @var m\MockInterface&Service */ | ||
| private $service; | ||
|
|
||
| /** | ||
| * @param string $testDescription | ||
| * @param array $expectation | ||
| * @param bool $testOidcngEnabled | ||
| * @param bool $oidcngEnabledForService | ||
| * @param bool $oidcEnabled | ||
| * | ||
| * @dataProvider provideTestVariations | ||
| */ | ||
| public function test_variations_test( | ||
| $testDescription, | ||
| $expectation, | ||
| $testOidcngEnabled, | ||
| $oidcngEnabledForService, | ||
| $oidcEnabled | ||
| ) { | ||
| $this->manageTestConfig | ||
| ->shouldReceive('getOidcngEnabled->isEnabled') | ||
| ->once() | ||
| ->andReturn($testOidcngEnabled); | ||
|
|
||
| $this->service | ||
| ->shouldReceive('isOidcngEnabled') | ||
| ->andReturn($oidcngEnabledForService); | ||
|
|
||
| $this->oidcCreateEnabledMarshaller | ||
| ->shouldReceive('allowed') | ||
| ->andReturn($oidcEnabled); | ||
|
|
||
| $testOptions = $this->protocolChoiceFactory->buildOptions(Entity::ENVIRONMENT_TEST); | ||
| $this->assertEquals($expectation, array_values($testOptions), $testDescription); | ||
| } | ||
|
|
||
| /** | ||
| * @param string $testDescription | ||
| * @param array $expectation | ||
| * @param bool $productionOidcngEnabled | ||
| * @param bool $oidcngEnabledForService | ||
| * @param bool $oidcEnabled | ||
| * | ||
| * @dataProvider provideTestVariations Note that the test generator is used, as for now behaviour is similar | ||
| * between prod and test | ||
| */ | ||
| public function test_variations_production( | ||
| $testDescription, | ||
| $expectation, | ||
| $productionOidcngEnabled, | ||
| $oidcngEnabledForService, | ||
| $oidcEnabled | ||
| ) { | ||
| $this->manageProdConfig | ||
| ->shouldReceive('getOidcngEnabled->isEnabled') | ||
| ->once() | ||
| ->andReturn($productionOidcngEnabled); | ||
|
|
||
| $this->service | ||
| ->shouldReceive('isOidcngEnabled') | ||
| ->andReturn($oidcngEnabledForService); | ||
|
|
||
| $this->oidcCreateEnabledMarshaller | ||
| ->shouldReceive('allowed') | ||
| ->andReturn($oidcEnabled); | ||
|
|
||
| $testOptions = $this->protocolChoiceFactory->buildOptions(Entity::ENVIRONMENT_PRODUCTION); | ||
| $this->assertEquals($expectation, array_values($testOptions), $testDescription); | ||
| } | ||
|
|
||
| public function provideTestVariations() | ||
| { | ||
| return [ | ||
| [ | ||
| 'All systems go, all options are set to true, so all options are displayed', | ||
| [ | ||
| 'saml20', | ||
| 'oidc', | ||
| 'oidcng', | ||
| 'oidcng_rs', | ||
| ], | ||
| true, | ||
| true, | ||
| true, | ||
| ], | ||
| [ | ||
| 'OIDC is disabled, all other options should be present', | ||
| [ | ||
| 'saml20', | ||
| 'oidcng', | ||
| 'oidcng_rs', | ||
| ], | ||
| true, | ||
| true, | ||
| false, | ||
| ], | ||
| [ | ||
| 'OIDC & OIDCng is disabled, Only SAML should be visible', | ||
| [ | ||
| 'saml20', | ||
| ], | ||
| false, | ||
| true, | ||
| false, | ||
| ], | ||
| [ | ||
| 'OIDCng is disabled for the service, Only SAML and OIDC should be visible', | ||
| [ | ||
| 'saml20', | ||
| 'oidc', | ||
| ], | ||
| true, | ||
| false, | ||
| true, | ||
| ], | ||
| ]; | ||
| } | ||
|
|
||
| protected function setUp() | ||
| { | ||
| $this->oidcCreateEnabledMarshaller = m::mock(OidcCreateEntityEnabledMarshaller::class); | ||
| $this->manageTestConfig = m::mock(Config::class); | ||
| $this->manageProdConfig = m::mock(Config::class); | ||
|
|
||
|
|
||
| $this->protocolChoiceFactory = new ProtocolChoiceFactory( | ||
| $this->manageTestConfig, | ||
| $this->manageProdConfig, | ||
| $this->oidcCreateEnabledMarshaller | ||
| ); | ||
| $this->service = m::mock(Service::class); | ||
| $this->protocolChoiceFactory->setService($this->service); | ||
| } | ||
| } |
Oops, something went wrong.