You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@SUGAM-ARORA Ihave added the facebook Authentication as well as improved the styling in some pages. Make sure to allow authentication of Facebook in Firebase. Kindly review this.
Type of PR
Bug fix
Feature enhancement
Documentation update
Other (specify): _______________
Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:
I have performed a self-review of my code
I have read and followed the Contribution Guidelines.
I have tested the changes thoroughly before submitting this pull request.
I have provided relevant issue numbers, screenshots, and videos after making the changes.
I have commented my code, particularly in hard-to-understand areas.
Additional context:
[Include any additional information or context that might be helpful for reviewers.]
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTE.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊
@SUGAM-ARORA Sir as per discussed earlier I have already done the authentication for Github, Phone and Facebook. Moreover I am in the process of raising the PR of twitter, microsoft. Just want to clarify from you whether to do authentication for LinkedIn also or not?
@SUGAM-ARORA Sir as per discussed earlier I have already done the authentication for Github, Phone and Facebook. Moreover I am in the process of raising the PR of twitter, microsoft. Just want to clarify from you whether to do authentication for LinkedIn also or not?
If possible then you can include Linkedin too. But ig firebase might not have Linkedin one directly. Might need to add external link
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #547
Description
@SUGAM-ARORA Ihave added the facebook Authentication as well as improved the styling in some pages. Make sure to allow authentication of Facebook in Firebase. Kindly review this.
Type of PR
Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:
Additional context:
[Include any additional information or context that might be helpful for reviewers.]