Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connected Cart Page #541

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

AkshitGarg24
Copy link
Contributor

@AkshitGarg24 AkshitGarg24 commented Jul 23, 2024

Fixes #514

The cart page has been connected to the cart icon. For this purpose, I have made a .js file because, in React, it's impossible to render an HTML file directly. So, I have made a .js file and connected it with the router at the '/cart' web address. Additionally, I have changed the background color of the container for a better look. As of now, I have not removed the index.html file from the project. If you want any further changes, just let me know.

Original HTML file -
Screenshot 2024-07-23 212937

After connecting with Cart Icon -

CartPage.mp4

Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uni-collab ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 4:02am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTE.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@SUGAM-ARORA SUGAM-ARORA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AkshitGarg24 Update branch

Copy link
Owner

@SUGAM-ARORA SUGAM-ARORA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@SUGAM-ARORA SUGAM-ARORA added gssoc GSSOC 2024 level2 25 points labels Jul 24, 2024
@SUGAM-ARORA SUGAM-ARORA merged commit 8bc377f into SUGAM-ARORA:main Jul 24, 2024
2 checks passed
@AkshitGarg24 AkshitGarg24 deleted the 514/Cart-Page branch July 24, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSOC 2024 level2 25 points
Projects
Development

Successfully merging this pull request may close these issues.

Feat: Connecting Cart Icon to Cart Page
2 participants