Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made several changes and fixed navbar responsiveness. #189

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

saketh-05
Copy link
Contributor

Related Issue

Issue no: #169

Description

Made changes to Container.css, Menu.css, Menu.js, TopContainer.js files. Implemented navbar correctly for mobile ,tab, etc. devices. This will fix most of the responsive navbar issues.

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]
Screenshot 2024-05-30 205243
pic2
pic3
pic4

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Made changes to Container.css, Menu.css, Menu.js, TopContainer.js files. Implemented navbar correctly for mobile ,tab etc devices. This will fix most of the responsive navbar issues.
Copy link

vercel bot commented May 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uni-collab ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2024 0:34am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.

Copy link
Owner

@SUGAM-ARORA SUGAM-ARORA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive updates @saketh-05 . Just one thing to do more - Update the branch with the latest updates

git checkout main
git pull
git checkout
git merge main
[ ... resolve any conflicts ... ]
git add [files that were conflicted]
git commit
git push

@saketh-05
Copy link
Contributor Author

@SUGAM-ARORA I have done what u said i.e. updating my branch with the latest updates from the main branch.

@saketh-05
Copy link
Contributor Author

@SUGAM-ARORA I have updated my branch, please go through my pull request, also I want to work on issue #170 please assign that to me as I have completed this issue

@saketh-05
Copy link
Contributor Author

@SUGAM-ARORA Please tell me if I should make any more changes. I will respond quickly. It took me lot time and effort to learn, analyse the issue and fix it 🥲.

Copy link
Owner

@SUGAM-ARORA SUGAM-ARORA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @saketh-05

@SUGAM-ARORA
Copy link
Owner

@saketh-05 Sorry for the delay from my side. Generally I take max 1-2 days to merge PR's. Moreover if there is a delay from my side in assigning any issue then you can start the work from your end.

@SUGAM-ARORA SUGAM-ARORA merged commit 6a7bb56 into SUGAM-ARORA:main Jun 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSOC 2024 level3 45 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants