-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made several changes and fixed navbar responsiveness. #189
Conversation
Made changes to Container.css, Menu.css, Menu.js, TopContainer.js files. Implemented navbar correctly for mobile ,tab etc devices. This will fix most of the responsive navbar issues.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Our repository.🎊 Thank you so much for taking the time to point this out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive updates @saketh-05 . Just one thing to do more - Update the branch with the latest updates
git checkout main
git pull
git checkout
git merge main
[ ... resolve any conflicts ... ]
git add [files that were conflicted]
git commit
git push
@SUGAM-ARORA I have done what u said i.e. updating my branch with the latest updates from the main branch. |
@SUGAM-ARORA I have updated my branch, please go through my pull request, also I want to work on issue #170 please assign that to me as I have completed this issue |
@SUGAM-ARORA Please tell me if I should make any more changes. I will respond quickly. It took me lot time and effort to learn, analyse the issue and fix it 🥲. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @saketh-05
@saketh-05 Sorry for the delay from my side. Generally I take max 1-2 days to merge PR's. Moreover if there is a delay from my side in assigning any issue then you can start the work from your end. |
Related Issue
Issue no: #169
Description
Made changes to Container.css, Menu.css, Menu.js, TopContainer.js files. Implemented navbar correctly for mobile ,tab, etc. devices. This will fix most of the responsive navbar issues.
Type of PR
Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:
Additional context:
[Include any additional information or context that might be helpful for reviewers.]