1081 remove qt5 support #1083
Merged
1081 remove qt5 support #1083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe needs improvement and simplification.
dlyr
force-pushed
the
1081-remove-qt5-support
branch
from
7b86e9d to
1d2e7a6
Compare
dlyr
force-pushed
the
1081-remove-qt5-support
branch
from
1c24611 to
8d0faf2
Compare
|
The PR CI do not pass with macos-latest maybe due to floating point rounding changes in compiler. Let's first drop qt5, then move to macos-latest in another PR. |
MathiasPaulin
approved these changes
Oct 9, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Check if you branch history is PR compatible
Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.
What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here)
Both qt5 and qt6 are supported, but the CI lacks support of qt5 (see #1081)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
If there is Qt5 specific configuration (in cmake) or code (in c++), user codes have to be updated.