Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldap_child: make sure invalid krb5 context is not used - 2.9.4 #7717

Closed

Conversation

sumit-bose
Copy link
Contributor

@sumit-bose sumit-bose commented Nov 21, 2024

Resolves: #7715

@sumit-bose sumit-bose force-pushed the invalid_krb5_context-sssd-2-9-4 branch from 9fc0eba to 9962fe5 Compare November 21, 2024 08:28
@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Nov 21, 2024

@sumit-bose, why 'sssd-2-9-4' explicitly and not 'sssd-2-9' (and maybe + backport to 'sssd-2-9-4')?

@alexey-tikhonov
Copy link
Member

Also commit message needs to be updated, since that's not about 'ldap_child' in sssd-2-9

@sumit-bose
Copy link
Contributor Author

@sumit-bose, why 'sssd-2-9-4' explicitly and not 'sssd-2-9' + backport to 'sssd-2-9-4'?

Hi,

oh, copy-n-paste error, do you know if it can be changed in the current PR or shall I open a new one?

bye,
Sumit

@alexey-tikhonov
Copy link
Member

@sumit-bose, why 'sssd-2-9-4' explicitly and not 'sssd-2-9' + backport to 'sssd-2-9-4'?

Hi,

oh, copy-n-paste error, do you know if it can be changed in the current PR or shall I open a new one?

If you click "edit" near title then you can change a base branch.

@sumit-bose sumit-bose changed the base branch from sssd-2-9-4 to sssd-2-9 November 21, 2024 13:43
@sumit-bose sumit-bose changed the base branch from sssd-2-9 to sssd-2-9-4 November 21, 2024 13:46
@sumit-bose sumit-bose force-pushed the invalid_krb5_context-sssd-2-9-4 branch from 9962fe5 to bdfb920 Compare November 21, 2024 16:19
@sumit-bose sumit-bose changed the base branch from sssd-2-9-4 to sssd-2-9 November 21, 2024 16:20
@sumit-bose
Copy link
Contributor Author

@sumit-bose, why 'sssd-2-9-4' explicitly and not 'sssd-2-9' + backport to 'sssd-2-9-4'?

Hi,
oh, copy-n-paste error, do you know if it can be changed in the current PR or shall I open a new one?

If you click "edit" near title then you can change a base branch.

Thanks for the hint, done.

@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Nov 21, 2024
@alexey-tikhonov
Copy link
Member

"ldap_child: " of commit message still needs an update.

@alexey-tikhonov alexey-tikhonov added Bugzilla branch: sssd-2-9-4 Corresponds to C8S and removed no-backport This should go to target branch only. labels Nov 21, 2024
@sumit-bose
Copy link
Contributor Author

Hi,

the fix for master was changed in #7716 and the new version can be backported directly, closing this PR.

bye,
Sumit

@sumit-bose sumit-bose closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants