ssh: do not use default_domain_suffix #7635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default_domain_suffix is already handled in the generic cache request code and the additional enforcement in the ssh responder might cause issue if fully-qualified names are used as input. With this change the ssh responder handles request data similar to the nss responder e.g. in sss_nss_protocol_parse_name(). Resolves: SSSD#7671
:relnote: The option default_domain_suffix is deprecated. Consider using the more flexible domain_resolution_order instead.
sumit-bose
force-pushed
the
ssh_default_domain
branch
from
540d9ce to
e7a9eb0
Compare
ikerexxe
approved these changes
Nov 8, 2024
alexey-tikhonov
approved these changes
Nov 14, 2024
|
ACK |
alexey-tikhonov
added
Accepted
Ready to push
|
Pushed PR: #7635
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default_domain_suffix is already handled in the generic cache
request code and the additional enforcement in the ssh responder might
cause issue if fully-qualified names are used as input.
With this change the ssh responder handles request data similar to the
nss responder e.g. in sss_nss_protocol_parse_name().
Resolves: #7671