Parse RPSL into borrowing ObjectView convertible to owned Object

Cargo.toml

@@ -24,6 +24,7 @@ thiserror = "1.0.50"
 [dev-dependencies]
 codspeed-criterion-compat = "2.3.3"
 criterion = { version = "0.5.1", features = ["html_reports"] }
+proptest = "1.4.0"
 
 [[bench]]
 name = "parse_as3257"

examples/print_parsed_as3257.rs

@@ -1,4 +1,9 @@
-use rpsl_parser::{parse_object, Object};
+use rpsl_parser::{parse_object, ObjectView};
+
+fn main() {
+    let aut_num_gtt: ObjectView = parse_object(AS3257).unwrap();
+    println!("{:#?}", aut_num_gtt);
+}
 
 const AS3257: &str = r#"aut-num:        AS3257
 as-name:        GTT-BACKBONE
@@ -9569,8 +9574,3 @@ last-modified:  2023-07-21T10:03:34Z
 source:         RIPE
 
 "#;
-
-fn main() {
-    let aut_num_gtt: Object = parse_object(AS3257).unwrap();
-    println!("{:#?}", aut_num_gtt);
-}

examples/print_parsed_as3257_whois_response.rs

@@ -1,4 +1,9 @@
-use rpsl_parser::{parse_whois_response, Object};
+use rpsl_parser::{parse_whois_response, ObjectView};
+
+fn main() {
+    let parsed_objects: Vec<ObjectView> = parse_whois_response(AS3257_WHOIS_RESPONSE).unwrap();
+    println!("{:#?}", parsed_objects);
+}
 
 const AS3257_WHOIS_RESPONSE: &str = r#"
 % Note: this output has been filtered.
@@ -9699,8 +9704,3 @@ source:         RIPE # Filtered
 
 
 "#;
-
-fn main() {
-    let parsed_objects: Vec<Object> = parse_whois_response(AS3257_WHOIS_RESPONSE).unwrap();
-    println!("{:#?}", parsed_objects);
-}

src/lib.rs

@@ -6,7 +6,7 @@
 
 pub use parser::{parse_object, parse_whois_response};
 pub use rpsl::error::AttributeError;
-pub use rpsl::{Attribute, Object};
+pub use rpsl::{Attribute, AttributeView, Object, ObjectView};
 
 mod parser;
 mod rpsl;

src/parser/component.rs

@@ -1,4 +1,4 @@
-use crate::rpsl::Attribute;
+use crate::rpsl::AttributeView;
 use nom::{
     bytes::complete::{tag, take_while},
     character::complete::{newline, space0},
@@ -24,21 +24,21 @@ pub fn server_message(input: &str) -> IResult<&str, &str> {
 // A RPSL attribute consisting of a name and one or more values.
 // The name is followed by a colon and optional spaces.
 // Single value attributes are limited to one line, while multi value attributes span over multiple lines.
-pub fn attribute(input: &str) -> IResult<&str, Attribute> {
+pub fn attribute(input: &str) -> IResult<&str, AttributeView> {
     let (remaining, (name, first_value)) = separated_pair(
         terminated(subcomponent::attribute_name, tag(":")),
         space0,
         terminated(subcomponent::attribute_value, newline),
     )(input)?;
 
     if peek(subcomponent::continuation_char)(remaining).is_err() {
-        Ok((remaining, Attribute::new(name, first_value).unwrap()))
+        Ok((remaining, AttributeView::new_single(name, first_value)))
     } else {
         let (remaining, continuation_values) = many0(subcomponent::continuation_line)(remaining)?;
-        let mut values: Vec<&str> = Vec::with_capacity(1 + continuation_values.len());
-        values.push(first_value);
-        values.extend(continuation_values);
-        Ok((remaining, Attribute::new(name, values).unwrap()))
+        let values = std::iter::once(first_value)
+            .chain(continuation_values)
+            .collect();
+        Ok((remaining, AttributeView::new_multi(name, values)))
     }
 }
 
@@ -78,7 +78,7 @@ mod tests {
             attribute("import:         from AS12 accept AS12\n"),
             Ok((
                 "",
-                Attribute::new("import", "from AS12 accept AS12").unwrap()
+                AttributeView::new_single("import", "from AS12 accept AS12")
             ))
         );
     }
@@ -94,15 +94,14 @@ mod tests {
             )),
             Ok((
                 "remarks:        Peering Policy\n",
-                Attribute::new(
+                AttributeView::new_multi(
                     "remarks",
                     vec![
                         "Locations",
                         "LA1 - CoreSite One Wilshire",
                         "NY1 - Equinix New York, Newark",
                     ]
                 )
-                .unwrap()
             ))
         );
     }