Use string regex within attribute value strategy to improve performance

SRv6d · Dec 14, 2023 · c14e90c · c14e90c
1 parent ae93322
commit c14e90c
Showing 1 changed file with 1 addition and 25 deletions.
diff --git a/tests/test_parsing.rs b/tests/test_parsing.rs
@@ -30,31 +30,7 @@ mod strategies {
     /// An attrbute value may consist of any ASCII characters excluding control and
     /// must not start with, or consist entirely of whitespace.
     fn attribute_value_content() -> impl Strategy<Value = String> {
-        (
-            prop_oneof![
-                proptest::char::ranges(['0'..='9'].as_slice().into()),
-                proptest::char::ranges(['a'..='z', 'A'..='Z'].as_slice().into()),
-                proptest::char::ranges(
-                    ['!'..='/', ':'..='@', '['..='`', '{'..='~']
-                        .as_slice()
-                        .into()
-                )
-            ],
-            proptest::collection::vec(
-                prop_oneof![
-                    Just(' '),
-                    proptest::char::ranges(['0'..='9'].as_slice().into()),
-                    proptest::char::ranges(['a'..='z', 'A'..='Z'].as_slice().into()),
-                    proptest::char::ranges(
-                        ['!'..='/', ':'..='@', '['..='`', '{'..='~']
-                            .as_slice()
-                            .into()
-                    )
-                ],
-                1..250,
-            ),
-        )
-            .prop_map(|(first, rest)| std::iter::once(first).chain(rest).collect())
+        proptest::string::string_regex("[!-~][ -~]*").unwrap()
     }
 
     /// An empty attribute value.