Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYNEXT-704 Adapt show access to new channel presentation with action sheet selector #537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mutaben
Copy link
Contributor

@mutaben mutaben commented Jan 28, 2025

Description

With the new PAC audio page, the show access A-Z button can now be ambiguous since many audio channels are displayed at once.

The design was left open to developer in order to be able to show the list.

I went with a simple and well known pattern, that would be the default for this kind of operation from the HIG, the action sheet.

Another design route is suggested in #539

Of course it is still open for discussion and we can totally revamp should a better proposal come to us.

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-01-28.at.20.18.12.mp4

Changes Made

  • Refactor a bit the helper methods to build showsViewController(...) method since with the action sheet, it not only needs to build a SectionViewController, but also select it asynchronously after user selection.
  • Wire the next VC according to user selection and and show it

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added the improvement Feature or update (issue and PR) - release notes section label Jan 28, 2025
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly January 28, 2025 19:13 Inactive
@rts-devops rts-devops requested a deployment to playsrg-tvos-nightly+PLAYNEXT-704-AZ-show-access-adaptation January 28, 2025 19:13 In progress
@mutaben mutaben force-pushed the PLAYNEXT-704-AZ-show-access-adaptation branch from 6d60012 to 387aad5 Compare January 28, 2025 19:23
@rts-devops rts-devops requested a deployment to playsrg-tvos-nightly+PLAYNEXT-704-AZ-show-access-adaptation January 28, 2025 19:26 In progress
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYNEXT-704-AZ-show-access-adaptation January 28, 2025 19:52 Inactive
@mutaben mutaben requested a review from waliid January 29, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants