Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAYRTS-5584 Remove Play SWI link in deployment pages #513

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented Aug 17, 2024

Description

Following #498, an unexpected Github page link is still displayed: On the deployment page, Play SWI link.

Example: https://srgssr.github.io/playsrg-apple/deployments/build.html?configuration=Nightly&platform=iOS&version=3.8.8-541+PLAYRTS-5578-ios18-update

Screenshot 2024-08-17 at 18 00 58

Changes Made

  • Remove Play SWI in Github deployment page code generator.

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@pyby pyby added improvement Feature or update (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section bug Issue to be fix (issue and PR) - release notes section and removed improvement Feature or update (issue and PR) - release notes section labels Aug 17, 2024
@pyby pyby requested review from defagos, mutaben and waliid August 17, 2024 16:05
@pyby pyby marked this pull request as ready for review August 17, 2024 16:05
@pyby
Copy link
Member Author

pyby commented Aug 17, 2024

Note

I ran the "Publish release notes" on the CI (fastlane publishReleaseNotes lane) from this branch to update and test Github pages update.
That's why now the shared link in the PR description is fine now.

@pyby pyby added this pull request to the merge queue Aug 18, 2024
Merged via the queue into develop with commit 9f1c2ca Aug 18, 2024
1 check passed
@pyby pyby deleted the feature/PLAYRTS-5584-remove-swi-on-gh-pages branch August 18, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue to be fix (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants