-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAYRTS-5566 SwiftFormat and trim trailing whitespaces #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c0218c4.
6 tasks
mutaben
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a developer
I want to have same default Xcode configuration for all developers and better swift format
so that new PRs don’t have whitespace issues and different swift styles.
Important
For developers:
brew install swiftformat
.Testing manually the Xcode UI menu "Structure / Re-Indent", SwiftFormat tools has been tested, and it looks interesting to have it for a better swift code style.
Following #483, add
swiftformat
lint in build phases to help developers to check formatting during debug compilation.Changes Made
swiftformat
inmake check-quality
andmake fix-quality
.swiftformat
linter in build phases.swiftformat
rules and Swift 5.10 updates.swiftformat
rules.Checklist