-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLAYRTS-5508 Beta only audio content pages #487
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for channel audio pages
…splay content audio homepage Instead of many radio channel homepages
…with audio content" This reverts commit 9115546.
rts-devops
temporarily deployed
to
playsrg-tvos-nightly+PLAYRTS-5508-audio-content-pages
May 29, 2024 16:47
Inactive
rts-devops
temporarily deployed
to
playsrg-ios-nightly+PLAYRTS-5508-audio-content-pages
May 29, 2024 16:47
Inactive
pyby
changed the title
PLAYRTS-5508 POC audio content pages
PLAYRTS-5508 Beta only audio content pages
May 29, 2024
pyby
added
improvement
Feature or update (issue and PR) - release notes section
internal
Ignore this PR in automatically generated release notes - no release notes section
and removed
internal
Ignore this PR in automatically generated release notes - no release notes section
labels
May 29, 2024
mutaben
approved these changes
May 30, 2024
Using `compactMap` instead of if/else Co-authored-by: Mustapha-Tarek <MustaphaTarek.Lechhab@rts.ch>
pyby
force-pushed
the
feature/PLAYRTS-5508-audio-content-pages
branch
from
May 31, 2024 11:09
f78da13
to
df97c65
Compare
rts-devops
temporarily deployed
to
playsrg-tvos-nightly+PLAYRTS-5508-audio-content-pages
May 31, 2024 13:17
Inactive
rts-devops
temporarily deployed
to
playsrg-ios-nightly+PLAYRTS-5508-audio-content-pages
May 31, 2024 13:18
Inactive
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR proposes an internal test only for audios tab with two options:
contentPageId
defined.It's also propose a internal test for show squared images, if supported by BU.
Changes Made
contentPageId
in channel remote configuration object.AudioHomepageOption
to select Audios tab content.SquareImages
to force radio show image to square.PageViewModel
.audio(channel: RadioChannel?)
channel Id can have a nullable channel, to support only Play Audio landing page.ContentType
enum to describevideoOrTV
,audioOrRadio
ormixed
content.SRGImageVariant
on show regarding theContentType
.Some "FIXME" added as for now, a section does not know itself if it's
videoOrTV
oraudioOrRadio
content in.Checklist