Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement navigation from swimlane to micropage (PLAYRTS-5527) #479

Merged
merged 12 commits into from
May 17, 2024

Conversation

mutaben
Copy link
Contributor

@mutaben mutaben commented May 14, 2024

Description

Micropages can now be set to be opened when entering a section, for instance for a timely event.
This PR implements the logic, fetching, and navigation aspects and relies on a new version of SRGDataProvider.

Changes Made

Checklist

  • I have followed the project's style guidelines.
  • I have performed a self-review of my own changes.
  • I have made corresponding changes to the documentation.
  • My changes do not generate new warnings.
  • I have tested my changes and I am confident that it works as expected and doesn't introduce any known regressions.
  • I have reviewed the contribution guidelines.

@mutaben mutaben added the improvement Feature or update (issue and PR) - release notes section label May 14, 2024
@mutaben mutaben requested a review from pyby May 14, 2024 14:46
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5527-swimlane-link-to-micropage May 14, 2024 15:34 Inactive
@rts-devops rts-devops had a problem deploying to playsrg-tvos-nightly+PLAYRTS-5527-swimlane-link-to-micropage May 14, 2024 15:34 Error
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYRTS-5527-swimlane-link-to-micropage May 14, 2024 19:53 Inactive
@mutaben mutaben force-pushed the feature/PLAYRTS-5527-swimlane-link-to-micropage branch from 2c1e074 to a404322 Compare May 16, 2024 09:30
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5527-swimlane-link-to-micropage May 16, 2024 09:44 Inactive
@rts-devops rts-devops had a problem deploying to playsrg-tvos-nightly+PLAYRTS-5527-swimlane-link-to-micropage May 16, 2024 09:45 Error
@rts-devops rts-devops had a problem deploying to playsrg-tvos-nightly+PLAYRTS-5527-swimlane-link-to-micropage May 16, 2024 14:25 Error
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+PLAYRTS-5527-swimlane-link-to-micropage May 16, 2024 14:26 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+PLAYRTS-5527-swimlane-link-to-micropage May 16, 2024 14:32 Inactive
@mutaben mutaben force-pushed the feature/PLAYRTS-5527-swimlane-link-to-micropage branch from e92cdfb to fa605df Compare May 17, 2024 09:42
Application/Sources/Content/PageViewModel.swift Outdated Show resolved Hide resolved
@mutaben mutaben force-pushed the feature/PLAYRTS-5527-swimlane-link-to-micropage branch from fa605df to 9d844c0 Compare May 17, 2024 09:53
@mutaben mutaben force-pushed the feature/PLAYRTS-5527-swimlane-link-to-micropage branch from 9502c97 to 967c57c Compare May 17, 2024 13:42
@mutaben mutaben added this pull request to the merge queue May 17, 2024
Merged via the queue into develop with commit 0911252 May 17, 2024
1 check passed
@mutaben mutaben deleted the feature/PLAYRTS-5527-swimlane-link-to-micropage branch May 17, 2024 13:57
@pyby pyby mentioned this pull request May 17, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Feature or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants