Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve beta Github deployments #454

Merged
merged 6 commits into from
Apr 7, 2024
Merged

Improve beta Github deployments #454

merged 6 commits into from
Apr 7, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented Apr 6, 2024

Motivation and Context

Following #447 and the first private and public betas (iOS and tvOS), the environment urls for private betas are wrong. Because of the bump build number commit during the workflow.

The deployment ref are links to the branch and could be links to the tag for more readiness.

Description

  • Add tag support for GitHub deployment creation.
  • Fix the environment urls for betas.
  • Replace GitHub deployment for betas if new tag is created during the workflow with one with tag as a ref.

Checklist

  • The branch should be rebased onto the develop branch for whole tests with nighties, but it's not required.*
  • The code followed the code style as make quality passes with a green tick on the last commit.
  • Remote configuration properties have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • Issues are linked to the PR, if any.

* The project uses Github merge queue feature, which rebases onto the develop branch before squashing and merging the PR.

@pyby pyby added the dev tool Dev tool improvement or update (issue and PR) - release notes section label Apr 6, 2024
@pyby pyby force-pushed the feature/gh-deployments branch from 677a9ea to 733550b Compare April 6, 2024 12:02
@pyby pyby added the internal Ignore this PR in automatically generated release notes - no release notes section label Apr 7, 2024
@pyby pyby marked this pull request as ready for review April 7, 2024 15:24
@rts-devops rts-devops temporarily deployed to playsrg-ios-nightly+gh-deployments April 7, 2024 15:45 Inactive
@rts-devops rts-devops temporarily deployed to playsrg-tvos-nightly+gh-deployments April 7, 2024 15:46 Inactive
@pyby pyby added this pull request to the merge queue Apr 7, 2024
Merged via the queue into develop with commit ea68542 Apr 7, 2024
3 checks passed
@pyby pyby deleted the feature/gh-deployments branch April 7, 2024 16:23
@pyby pyby added CI CI workflow improvement or update (issue and PR) - release notes section and removed dev tool Dev tool improvement or update (issue and PR) - release notes section labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI workflow improvement or update (issue and PR) - release notes section internal Ignore this PR in automatically generated release notes - no release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants