Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment status updated after PR closure #449

Merged
merged 8 commits into from
Apr 4, 2024

Conversation

pyby
Copy link
Member

@pyby pyby commented Mar 30, 2024

Motivation and Context

The CI can now shared deployment with #447.
When a PR si closed, the GitHub branch is deleted.
Like Play web deployments, the PR merge is set inactive the deployment.

Description

  • Add a Github action to fallow PR closure and update the latest deployments for iOS and tvOS nighties.

No in this PR

  • Take care of "playsrg-beta" and "playsrg-testflight" environments. They should not have brand environments.

Checklist

  • The branch should be rebased onto the develop branch for whole tests with nighties, but it's not required.*
  • The code followed the code style as make quality passes with a green tick on the last commit.
  • Remote configuration properties have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • Issues are linked to the PR, if any.

* The project uses Github merge queue feature, which rebases onto the develop branch before squashing and merging the PR.

@pyby pyby added the dev tool Dev tool improvement or update (issue and PR) - release notes section label Mar 30, 2024
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 🚀 :shipit:

@amtins amtins added this pull request to the merge queue Apr 4, 2024
Merged via the queue into develop with commit 4a1f11f Apr 4, 2024
1 check passed
@amtins amtins deleted the feature/gh-pr-closure-action branch April 4, 2024 17:07
@pyby pyby added CI CI workflow improvement or update (issue and PR) - release notes section and removed dev tool Dev tool improvement or update (issue and PR) - release notes section labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI workflow improvement or update (issue and PR) - release notes section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants