[Feat/#64] 퀴즈 풀기 화면 디테일 수정 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,19 +12,19 @@ import ComposableArchitecture | |||
| import Moya | |||
|
|
|||
| struct NewsClient { | |||
| var fetchNewsList: (Int, Int) async -> Result<[NewsEntity], D3NAPIError> | |||
| var fetchQuizList: (Int) async -> Result<[QuizEntity], D3NAPIError> | |||
| var fetch: (Int, Int) async -> Result<[NewsEntity], D3NAPIError> | |||
There was a problem hiding this comment.
fetch가 하나로 합쳐전 건 이제 한 번에 뉴스와 퀴즈를 동시에 보내주도록 백엔드에서 수정되어서인지 궁금합니다!
There was a problem hiding this comment.
두개로 분리한거입니다! �API 명세는 그대로이고, 기존에 NewsClient가 모두를 fetch 하였는데 NewsClient와 QuizClient로 분리하였습니다. 이름은 이제 NewsClient가 fetch 하는 것은 News 라는 것이 암묵적이라고 생각하여 네이밍에서 키워드를 생략하였습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 요약
📌 변경 사항
✅ PR check list
Linked Issue
close #64