[Feat/56] 전체 뉴스 창 추가 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mooyoung2309
approved these changes
Nov 14, 2023
| @@ -57,7 +57,7 @@ public struct TodayNavigationStackStore: Reducer { | |||
| QuizResultStore() | |||
| } | |||
| Scope(state: /State.newsList, action: /Action.newsList) { | |||
| NewsListStore() | |||
| AllNewsStore() | |||
| @@ -36,14 +36,14 @@ public struct TodayNavigationStackStore: Reducer { | |||
| case detail(TodayDetailStore.State) | |||
| case quizMain(QuizMainStore.State) | |||
| case quizResult(QuizResultStore.State) | |||
| case newsList(NewsListStore.State) | |||
| case newsList(AllNewsStore.State) | |||
There was a problem hiding this comment.
요기 case 이름을 allnews로 변경해도 좋을 것 같아요. (밑에 action도요!)
There was a problem hiding this comment.
거기까지는 생각을 못했네요! 바꾼 후 머지하도록 하겠습니다!
There was a problem hiding this comment.
@greetings1012 제가 버그 고치면서 같이 작업하겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 요약
📌 변경 사항
✅ PR check list
Linked Issue
close #56