Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Control - DBW] DBW Steering Disengage Method #244

Open
menson168 opened this issue Apr 7, 2019 · 6 comments
Open

[Control - DBW] DBW Steering Disengage Method #244

menson168 opened this issue Apr 7, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request experiment Testing potentially short-lived modifications

Comments

@menson168
Copy link
Collaborator

There should be a seamless way to disengage the autonomy mode and recover. @joeyzhu00 and @nathansrinivasan5 please work together with me on brainstorming a solution for this issue.

@menson168 menson168 added enhancement New feature or request experiment Testing potentially short-lived modifications labels Apr 7, 2019
@joeyzhu00
Copy link
Collaborator

We can experiment with using a button to engage and disengage the steering. I can add logic to stop sending CAN messages if the disengaged status is published as true.

@joeyzhu00
Copy link
Collaborator

We can also experiment with the built-in torque-sensing capabilities of the EPAS motor, but there is some noise associated with it that have to be addressed (false positives from the output of the motor).

@menson168
Copy link
Collaborator Author

We can experiment with using a button to engage and disengage the steering. I can add logic to stop sending CAN messages if the disengaged status is published as true.

We can also experiment with the built-in torque-sensing capabilities of the EPAS motor, but there is some noise associated with it that have to be addressed (false positives from the output of the motor).

I think the button/switch approach is desirable in the consideration of deployment time. Will probably require less analysis than studying how to not run into false-positives on the torque sensor.

@nathansrinivasan5
Copy link
Contributor

In the scenarios we have faced before when we needed to disengage the steering, do we have to know where the next nearest waypoint is when engaging it again?

@drofp
Copy link
Collaborator

drofp commented Apr 7, 2019

In the scenarios we have faced before when we needed to disengage the steering, do we have to know where the next nearest waypoint is when engaging it again?

Just check in Rviz if we have to keep going afterwards

@menson168
Copy link
Collaborator Author

In the scenarios we have faced before when we needed to disengage the steering, do we have to know where the next nearest waypoint is when engaging it again?

Just check in Rviz if we have to keep going afterwards

The re-engage position can also be just an approximately nearby location with respect to the path. The controller would notify in error if you are too far off the path. (Donut Selector)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request experiment Testing potentially short-lived modifications
Projects
None yet
Development

No branches or pull requests

4 participants