Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sparql #17

Merged
merged 14 commits into from
Sep 2, 2024
Merged

update sparql #17

merged 14 commits into from
Sep 2, 2024

Conversation

Treesarj
Copy link
Collaborator

@Treesarj Treesarj commented Aug 28, 2024 •
edited
Loading

Description:

This updates the feature that fetch the relations from KG when graph uri is provided in the mapping strategy.
Updates are:

  • The SPARQL query is modified to fetch all the properties with the required predicates of the selected sub graph
  • The SPARQL query was modified to include the full graph if no common parent class was found

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist for the reviewer:

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand, including clearly named variables?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@Treesarj Treesarj self-assigned this Aug 28, 2024
@Treesarj Treesarj requested a review from quaat August 28, 2024 08:52
quaat
quaat requested changes Aug 28, 2024
View reviewed changes
oteapi_dlite/strategies/mapping.py Outdated Show resolved Hide resolved
oteapi_dlite/strategies/mapping.py Show resolved Hide resolved
@Treesarj Treesarj requested a review from quaat August 28, 2024 15:15
@Treesarj Treesarj force-pushed the update-mapping-strategy branch from 44d8e9d to a36260e Compare September 2, 2024 08:52
@Treesarj Treesarj merged commit 261db06 into master Sep 2, 2024
8 of 9 checks passed
@CasperWA CasperWA deleted the update-mapping-strategy branch September 2, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quaat quaat quaat approved these changes

Assignees

@Treesarj Treesarj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Treesarj @quaat