Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated gitignore files #695

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Updated gitignore files #695

merged 2 commits into from
Nov 8, 2023

Conversation

jesper-friis
Copy link
Collaborator

Description

Cleaned up .gitignore files.

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

bindings/python/triplestore/__pycache__

# Documentation
pydoc/autoapi/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are included in the top-level gitignore file.

@francescalb
Copy link
Collaborator

Is the reason for this clean-up is to move gitignore to the parent directory?

Also, there are quite a few thigns that are not only moved but removed, why?

@jesper-friis
Copy link
Collaborator Author

Is the reason for this clean-up is to move gitignore to the parent directory?

Also, there are quite a few thigns that are not only moved but removed, why?

Most of what is removed was an unnecessary duplication of the toplevel .gitignore file. There were also some too wide entries that matched too much.

@jesper-friis jesper-friis merged commit 1d1543f into master Nov 8, 2023
@jesper-friis jesper-friis deleted the update-gitignore branch November 8, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants