Skip MinIO test when the MinIO playground is not responding or filled up #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilable or its storage is filled up by other users. Skip the minio tests in these cases instead of failing the whole dlite test suite. Bumped up the CMake requirements to 3.16 such that we can use the SKIP_REGULAR_EXPRESSION test property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The MinIO tests often fails due to the MinIO playground not being available or its storage is filled up by other users.
Instead of failing the whole DLite test suite, it is highly preferable to just mark the MinIO tests as skipped in these cases.
Tried to implement this PR at the CMake level to avoid unnecessary complicating the
minio_storageexample. However, CMake unfortunately doesn't support combining the TIMEOUT and SKIP_REGULAR_EXPRESSION test properties (as also noted by https://stackoverflow.com/questions/49153984/non-failing-timeout-using-ctest), so timeout was moved to Python.We currently have not timeout in the
test_miniocmake test since dlite.Storage doesn't implement timeout. Issue #1067 has been added to address that.Also bumped up the CMake requirements to 3.16 such that we can use the SKIP_REGULAR_EXPRESSION test property.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.