Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS - changes to the core code to allow DLite to compile on MacOS #1064

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nameloCmaS
Copy link

Description

To allow compiling on MacOS, this update includes:

  • Pre-processor updates.
  • Switch changes for code handling files.

See #1060 for proposed changes.

Commentary per file

byteorder.h.in

  • Added generated comment at top of file as a warning once processed.
  • Including error in preprocessor HAVE__BYTESWAP_* (missing double underscore).
  • Added MacOS equivalents of endian.h and byteswap.h plus defines to align naming of functions.

getopt.h

  • Moved #ifndef _GETOPT_H_ after #include statement as original position prevented the loading of getopt.h (at least on MacOS).

config.h.in

  • Added HAVE_ defines that were set in the CMake config but unused in the codebase.
  • Uncommented have statements as these were set in the CMake config.

Remaining files

  • Pre-processor updates.
  • Switch changes for code handling files.
  • Updated doxygen comments where function name was incorrect in fileutils.c.

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

…Pre-processor updates, lib changes, and switch changes for code handling files.
@nameloCmaS nameloCmaS mentioned this pull request Jan 9, 2025
7 tasks
Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fixes and consistency improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants