Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitignore files #1063

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

nameloCmaS
Copy link

Description

Added:

  • Typical folder names used for Python Virtual Env's / venv
  • CTest created folder is added
  • VS Code workspace and moved config folder to a new heading in the file
  • Added additional filetype for Python binding test outputs

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@nameloCmaS nameloCmaS mentioned this pull request Jan 9, 2025
7 tasks
*.code-workspace

# For CTest
/Testing/*
Copy link
Collaborator

@jesper-friis jesper-friis Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best practice is to run cmake from a separate build directory. In that case /Testing/ will be in that directory and not needed to be included in .gitignore.

However, it doesn't hurt to keep in .gitignore either, so if you think it is useful to have, we can keep it as well.

@jesper-friis jesper-friis self-requested a review January 11, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants