Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVM proxy settings are ignored #197

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

krizmanmarko
Copy link

JVM proxy settings (http.proxyHost, http.proxyPort, https.proxyHost, https.proxyPort) are ignored when using RequestConfig.custom(). Such fetches completely ignore http(s) proxy.

This behaviour was observed in 3 files:

  • /src/main/java/nl/sidnlabs/entrada/enrich/resolver/CloudFlareResolverCheck.java
  • /src/main/java/nl/sidnlabs/entrada/enrich/resolver/OpenDNSResolverCheck.java
  • /src/main/java/nl/sidnlabs/entrada/util/DownloadUtil.java

System properties can be enabled using the following changes and adding options to JAVA_OPTS.

krizmanmarko and others added 2 commits January 4, 2024 16:04
JVM proxy settings (http.proxyHost, http.proxyPort, https.proxyHost, https.proxyPort)
are ignored when using RequestConfig.custom(). Such fetches completely ignore http(s)
proxy. System properties can be taken into account by using an extra function
useSystemProperties() on HttpClientBuilder object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant