Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercises & learning objectives #20

Open
qdread opened this issue Sep 29, 2020 · 2 comments
Open

Exercises & learning objectives #20

qdread opened this issue Sep 29, 2020 · 2 comments

Comments

@qdread
Copy link
Contributor

qdread commented Sep 29, 2020

I think the exercises are generally good in terms of how they are written and the level of difficulty, but I had some comments on a couple of them from a pedagogical standpoint.

  • For the first exercise, walk2 is used but the difference between map and walk is not really explained in the lesson, nor is the *2. I think that can be fine if you want people to figure it out for the exercise, but those are also important features of the purrr package, so might be worth explaining in the lesson.
  • For exercises 4 and 7 where you have people monkeying with ggplot2 formatting, I think maybe there is the potential where people can get bogged down in trial and error trying to figure out how to get it just right. It might not further the learning objectives that much. But then again you do say it's a bonus so maybe that's fine 😀
@khondula
Copy link

khondula commented Oct 7, 2020

removed previous exercise 4, but leaving open to address other issues. asking too much in exercise 1 - introduce at least either map2 or walk before asking about walk2

make solution for exercise 7 is separate issue - maybe label as a challenge or something else since its more advanced

@khondula
Copy link

More specifics for future improvements to expand section on map functions to make it clearer what the family of functions is and what the main arguments are. Essentially provide enough content in the lesson to be able to do exercise 1 without too much new info

  • Include an example with a vector of a specific type like map_int before introducing map_dfr.
  • show how to use functions with 2 arguments, show or link to info about pmap for n arguments
  • maybe explain difference between map and walk functions

reblake added a commit that referenced this issue Jan 27, 2022
adds caution sign to top of lesson pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants