Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake configuration cleanup #7

Open
wrtobin opened this issue May 16, 2018 · 1 comment
Open

CMake configuration cleanup #7

wrtobin opened this issue May 16, 2018 · 1 comment
Assignees
Milestone

Comments

@wrtobin
Copy link
Collaborator

wrtobin commented May 16, 2018

The current CMakeLists.txt needs to be cleaned up and made to reflect current CMake best practices.

Our methods of finding and specifying dependencies need some work, and we need to break the configuration down into separate per-directory CMakelists.txt instead a single monolithic configuration file.

@wrtobin wrtobin self-assigned this May 16, 2018
@wrtobin wrtobin added this to the 0.1 milestone May 16, 2018
@cwsmith
Copy link
Contributor

cwsmith commented Jun 1, 2018

So far, I've found that
https://github.com/SCOREC/msi/blob/fusion/cmake/FindHdf5.cmake
and
https://github.com/SCOREC/msi/blob/fusion/cmake/FindPetsc.cmake
will fail cmake (FATAL_ERROR) if libraries or headers are missing. They should not fail, the CMakeLists.txt that calls them should decide if what they found meets the requirements.

I've started some cleanup here:
https://github.com/SCOREC/msi/tree/cws/cmake_cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants