fix: [Destinations] Allow for Custom Proxy Config in ON_PREMISE Destinations #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatKuhr
added
please merge
newtork
approved these changes
Feb 26, 2024
MatKuhr
deleted the
fix/onpremise-destination-proxyconfig-force-override
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Previously, any invocation to
proxy(..)onDefaultHttpDestination.Builderwas meaningless, if the destination has the proxy type `ON_PREMISE, because the value would be overriden when adding the on-prem logic.This change is handy for local testing (where you need to set the proxy URL to localhost) or any scenario where a non-default connectivity proxy config is used.
Definition of Done
Error handling created / updated & covered by the tests aboveDocumentation updated