Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a note to a current bug #43

Closed
wants to merge 1 commit into from

Conversation

John-H-Smith
Copy link

If using a line item criticality with a qualifier, at least one field without a qualifier must be included in the view to take effect. This is probably a bug, maybe should be escalated to the devs.

If using a line item criticality with a qualifier, at least one field without a qualifier must be included in the view to take effect.
This is probably a bug, maybe should be escalated to the devs.
@cla-assistant
Copy link

cla-assistant bot commented Feb 28, 2023

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Feb 28, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KvM2
Copy link
Contributor

KvM2 commented Feb 28, 2023

Hi @John-H-Smith , thanks for your contribution. We appreciate it and will look into this.

@JannaLisa
Copy link
Contributor

Hello @John-H-Smith ,
I'm still waiting for a response from my team on this. Will let you know as soon as I have an answer.

@GwendalMoreau
Copy link

@John-H-Smith : this seems to be a bug and should be treated as such (and not a a note in the documentation). Could you share your use case or raise a ticket?

Copy link

@GwendalMoreau GwendalMoreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@John-H-Smith : this seems to be a bug and should be treated as such (and not a a note in the documentation). Could you share your use case or raise a ticket?

@John-H-Smith
Copy link
Author

John-H-Smith commented Mar 6, 2023

Hi @GwendalMoreau ,
Alright, I will share my use case.
I created a cds view entity in the backend with associations to a child view.
As that child view should be on its own table in the object page, I've set a qualifier on all fields and the view and even the line criticality. But the line item criticality wasn't shown on the table, so I added (in trial) a field without any qualifiers. And then, the criticality was shown.

@GwendalMoreau
Copy link

@John-H-Smith : could you share your application metadata?

@OlMue
Copy link
Contributor

OlMue commented May 2, 2023

Hi @John-H-Smith, could please give @GwendalMoreau some information on the metadata? Thank you! :-)

@OlMue OlMue added the needs-more-info We need more info from the contributor to proceed label May 30, 2023
@OlMue
Copy link
Contributor

OlMue commented May 30, 2023

Hi there 👋 There's been no activity on this issue for a while, so we're closing it. If you've further information to provide, please comment below and add that information. We'll review it and reopen the conversation if necessary. Until next time, thanks!

@OlMue OlMue closed this May 30, 2023
@OlMue OlMue added couldn't-be-clarified Closed because we didn't hear back. and removed needs-more-info We need more info from the contributor to proceed labels May 30, 2023
@OlMue OlMue added the invalid This doesn't seem right label Nov 24, 2023
@OlMue OlMue added not-doc-issue Reported issue is not a documentation issue. and removed invalid This doesn't seem right labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
couldn't-be-clarified Closed because we didn't hear back. not-doc-issue Reported issue is not a documentation issue. SAP Fiori elements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants