Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color image support #1

Open
ckldan520 opened this issue Nov 21, 2019 · 11 comments
Open

color image support #1

ckldan520 opened this issue Nov 21, 2019 · 11 comments
Labels
enhancement New feature or request

Comments

@ckldan520
Copy link

Thanks for your good work. Will you consider supporting color image denoising in the future?

@Ryanshuai
Copy link
Owner

Thanks for your good work. Will you consider supporting color image denoising in the future?

I definitely will support color images. I am really busy now. Can you wait for about 1 or 2 months?

@ckldan520
Copy link
Author

Thank you very much!

@Ryanshuai Ryanshuai added the enhancement New feature or request label Nov 23, 2019
@YuMeng2v
Copy link

Thanks for your work! Can you write more comments to your code ?

@ckldan520
Copy link
Author

Why does the line 25 of bm3d_1st_step.py require that the height and width of img_noisy be equal? This will require the height and width of the original input image to be equal. For example, if I input a 256 * 320 image, there will be some bugs in the program.

@Ryanshuai
Copy link
Owner

@ckldan520
Yeah, you are right. This is a problem. Cause We only need square pictures for experiments.
You can either wait for me to fix this or fix it by yourself and pull request.
I think I will fix this in one month.

@Ryanshuai
Copy link
Owner

@ckldan520 I fixed the bug that the image height must be equal to the width, images with different widths and heights work fine now.

@ckldan520
Copy link
Author

@ckldan520 I fixed the bug that the image height must be equal to the width, images with different widths and heights work fine now.

Thank you very much, it works fine now

@TongWenQian
Copy link

Thank you for your excellent work. Will you continue to change BM3D to support color images?

@Ryanshuai
Copy link
Owner

Ryanshuai commented Oct 10, 2021

Thank you for your excellent work. Will you continue to change BM3D to support color images?

I don't think I have time to read the paper. I just read some other codes of BM3D, and I believe it only involves two color transforms. But I must verify the code before releasing it. The verification workload is huge. And I have always been trying to refactor this code, and it also takes time.

@Ryanshuai
Copy link
Owner

Thank you for your excellent work. Will you continue to change BM3D to support color images?

https://webpages.tuni.fi/foi/GCF-BM3D/
This is a python implementation that encapsulates CPP. The color transform is not encapsulated in CPP.
You can refer to this one.

@TongWenQian
Copy link

Thank you for your excellent work. Will you continue to change BM3D to support color images?

https://webpages.tuni.fi/foi/GCF-BM3D/ This is a python implementation that encapsulates CPP. The color transform is not encapsulated in CPP. You can refer to this one.

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants