Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dark mode added to options page #75

Merged
merged 2 commits into from
Oct 30, 2022
Merged

dark mode added to options page #75

merged 2 commits into from
Oct 30, 2022

Conversation

jhamadhav
Copy link
Contributor

Toggle buttons added to option page to toggle between dark/light mode

  • Styles folder added to hold CSS files
  • Added SCSS to have better CSS compatibility

@jhamadhav
Copy link
Contributor Author

jhamadhav commented Oct 21, 2022 •
edited
Loading

This PR is for Issue #42

@Rutuj-Runwal Rutuj-Runwal self-requested a review October 30, 2022 06:54
Rutuj-Runwal
Rutuj-Runwal requested changes Oct 30, 2022
View reviewed changes
Copy link
Owner

@Rutuj-Runwal Rutuj-Runwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for adding scss here.
Can be done in a separate pr

Keep the css in place itself

@Rutuj-Runwal Rutuj-Runwal self-requested a review October 30, 2022 17:50
Rutuj-Runwal
Rutuj-Runwal approved these changes Oct 30, 2022
View reviewed changes
Copy link
Owner

@Rutuj-Runwal Rutuj-Runwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work

@Rutuj-Runwal Rutuj-Runwal merged commit c483ccc into Rutuj-Runwal:main Oct 30, 2022
@Rutuj-Runwal Rutuj-Runwal added hacktoberfest-accepted Accepted contributions from hacktoberfest enhancement New feature or request labels Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rutuj-Runwal Rutuj-Runwal Rutuj-Runwal approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request hacktoberfest-accepted Accepted contributions from hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhamadhav @Rutuj-Runwal