Update actions #825
Merged
Update actions #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
other checkout
simlay
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Not like a review from me was requested, but this looks pretty good.
I think my only feedback would be to suggest adding dependabot for actions. coreaudio-sys and coreaudio-rs do this. It obviously wouldn't help with moving from actions-rs/toolchain to dtolnay/rust-toolchain but it would automate the PRs for actions/checkout (at the cost of a little bit of spam).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even on a successful run, GitHub actions have a lot of warnings:
This PR updates actions:
actions/checkoutto the latest v4actions-rs/toolchainbydtolnay/rust-toolchain. also use it instead of manual target installs at some placesactions-rs/cargoby running the cargo commandactions-rs/clippy-checkby running clippymymindstorm/seup-emsdkto the latest v14 (and also don't depend on an old version of emscripten as the bug linked as been fixed)katyo/publish-cratesto the latest v2 (I couldn't test this one)actions-rsactions have not been updated for 3 years and were archived in October 2023